Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Testing get for filter and user id #502

Open
wants to merge 6 commits into
base: staging
Choose a base branch
from
Open

Testing get for filter and user id #502

wants to merge 6 commits into from

Conversation

asehgal4
Copy link
Contributor

No description provided.

@Nydauron
Copy link
Contributor

Wait until #498 gets merged before reviewing this.

@Nydauron Nydauron force-pushed the get_for_filter_and_user_id branch from abb1e0c to 3a73f1e Compare January 12, 2023 03:24
Nydauron
Nydauron suggested changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@Nydauron Nydauron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests to add:

  • GET /user/filter/
    • Add multi-filter test for
    • Try to filter as a normal user and an unauthenticated user
  • GET /user/{id}/
    • Try to get by id as a normal user and an unauthenticated user
    • Add not found test

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nydauron Nydauron Nydauron requested changes

@Timothy-Gonzalez Timothy-Gonzalez Awaiting requested review from Timothy-Gonzalez

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asehgal4 @Nydauron