Update buy ins #72
Update buy ins #72
Conversation
tests/update-buy-ins.test.ts
Outdated
| total_points: 15, | ||
| buy_ins: [ | ||
| { prize_id: 'prize1', buy_in: 5 }, | ||
| { prize_id: 'prize2', buy_in: 10 }, |
There was a problem hiding this comment.
wouldn't this be 10 + 5 = 15? if the user has 15 points, then they should be able to spend 15 points. perhaps just do one point over
|
Hi @poojakedia, there are few things you could do to improve this. Right now, I will do the changes for you so no worries. Instead of nesting if statements, you could use something called Guard Clauses to improve the readability of your code. Because the if statements were nested, it looks like you forgot to return an error when the lengths of buy ins and requested buy ins are not equal. When testing on Postman, I got a 502 Bad Gateway error instead of a more productive error message when the buy_in array had differing array lengths. Those are the things I see at first glance, but thank you so much for you work! We are really happy for your contributions and I think the hundreds of hackers that will be using your work will appreciate it as well :) !!! |
No description provided.