✨ feat(datepicker): add full disabled state support across all picker modes #5890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balajis-qb
force-pushed
the
issue-5620/support-disabled
branch
from
bfbff36 to
4a22d14
Compare
- Added a `disabled` prop to the DatePicker, affecting all date selection components (Day, Month, Year, etc.) to visually indicate disabled states. - Updated styles to reflect disabled states, including cursor and color changes. - Modified utility functions to check for disabled dates. - Ensured that all date-related components respect the disabled state, preventing user interaction when disabled. - Updated tests to verify the disabled functionality across various scenarios. This change improves accessibility and user experience by clearly indicating when the DatePicker is not interactive. Closes Hacker0x01#5620
balajis-qb
force-pushed
the
issue-5620/support-disabled
branch
from
4a22d14 to
496cb6e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5890 +/- ##
==========================================
+ Coverage 97.26% 97.29% +0.02%
==========================================
Files 30 30
Lines 3443 3470 +27
Branches 1455 1472 +17
==========================================
+ Hits 3349 3376 +27
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
can you merge this with the main branch? |
martijnrusschen
approved these changes
Sep 30, 2025
|
sure @martijnrusschen , I'll resolve and merge, give me sometime |
|
@martijnrusschen , Merge PR option is not showing for me. I think as I updated the PR, it's not showing. Could you please merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5620
Description
Problem
As mentioned in the linked ticket, Currently,
disabledeffectively worked only for non-inline datepickers due to the nativeinput[disabled]behavior. When rendered withinline, users could still interact with the calendar and modify dates.Changes
The
disabledprop is now applied consistently across all picker modes, includinginline, ensuring the datepicker becomes non-interactive whendisabledistrue.--disabledmodifiers.Screenshots
Contribution checklist