Open
Conversation
s-fletcher
approved these changes
Jul 16, 2020
Contributor
There was a problem hiding this comment.
LGTM! I'll make sure to hook this into the front end eventually.
It looks like your tests are failing because of some linting errors. This is probably because I added a new rule a while back but never updated the other files. If you can force merge this, go ahead. If not, don't worry about it and I can merge it later.
| if (hacker.graduation && | ||
| hacker.levelOfStudy === "Undergraduate University" || | ||
| hacker.levelOfStudy === "Tech School") { | ||
| if (+year + +3 === +hacker.graduation) { |
Contributor
There was a problem hiding this comment.
Is +year just parsing it into an integer? I've seen that in your code and never really understood it.
| 'trades': [], | ||
| 'other': [], | ||
| }, | ||
| graduationYear: { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the calculations for graduations years. Currently checks to see what year they are graduating and what year it currently is. Compares it based off of the fact that Hacklahoma occurs in the spring.