Skip to content

Commit

Permalink
fix: use pre-commit for lint checks
Browse files Browse the repository at this point in the history
  • Loading branch information
tazlin committed Oct 1, 2023
1 parent 87e7c57 commit 5ca13ad
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 12 deletions.
10 changes: 4 additions & 6 deletions .github/workflows/maintests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
- 'tox.ini'
- '.github/workflows/maintests.yml'
- '.github/workflows/prtests.yml'
- '.github/workflows/release.yml'
- '.github/workflows/release.yml'
jobs:
build:

Expand All @@ -29,13 +29,11 @@ jobs:
with:
python-version: ${{ matrix.python }}
- name: Install tox and any other packages
run: |
run: |
python -m pip install --upgrade pip
pip install --upgrade -r requirements.dev.txt
- name: Run format check
run: tox -e format
- name: Run lint check
run: tox -e lint-weak-check
- name: Run lint/format/mypy check
run: tox -e pre-commit
- name: Check build_helper.py hordelib imports have no breaking dependency changes
run: tox -e test-build-helper
- name: Build unit test environment, confirm CUDA is available on host
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/prtests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
- 'tox.ini'
- '.github/workflows/maintests.yml'
- '.github/workflows/prtests.yml'
- '.github/workflows/release.yml'
- '.github/workflows/release.yml'
jobs:
build:

Expand All @@ -34,13 +34,11 @@ jobs:
with:
python-version: ${{ matrix.python }}
- name: Install tox and any other packages
run: |
run: |
python -m pip install --upgrade pip
pip install --upgrade -r requirements.dev.txt
- name: Run format check
run: tox -e format
- name: Run lint check
run: tox -e lint-weak-check
- name: Run lint/format/mypy check
run: tox -e pre-commit
- name: Check build_helper.py hordelib imports have no breaking dependency changes
run: tox -e test-build-helper
- name: Build unit test environment, confirm CUDA is available on host
Expand Down

0 comments on commit 5ca13ad

Please sign in to comment.