Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unload from RAM as intended; force empty cache #310

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Commits on Aug 24, 2024

  1. fix: unload from RAM as intended; force empty cache

    Prior to this commit the following erroneous behavior was in play:
    
    - `unload_all_models_vram()` did not effectively remove all models from VRAM
    - `unload_all_models_ram()` did not remove any models from RAM
    - With AMD specifically, though its possible more generally as well, the torch cache was not cleared as this required an argument (`True`) sent to `_comfy_soft_empty_cache(...)`
    
    I have also added some additional logging to help further identify what is and is not helpful.
    tazlin committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    a6ec17d View commit details
    Browse the repository at this point in the history