fix: don't abandon job on bad lora file #330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if a LoRa was bad (malformed) on disk it would case the entire job to crash. However, this is not intended; the job should limp forward as would be the case with other forms of LoRa related errors (such as a download failure or baseline mismatches). This change catches any comfyui internal loading related errors and falls back to the model passed to the node (without any changes made within the current call of the lora load).