Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: comfyui 3bb4dec; torch >=2.4.1 and cu124 by default #343

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

tazlin
Copy link
Member

@tazlin tazlin commented Sep 30, 2024

  • See the diff for ComfyUI from the last update here: comfyanonymous/ComfyUI@ca08597...3bb4dec
  • Sets the minimum torch to 2.4.1
  • For within this library, CUDA 12.4 is now used by default (does not automatically propagate to the worker; the top line of requirements.txt is commented out at build/push-to-pypi time).

This fixes the problem originating in `lora.py` of comfyui with the line `do_pad_weight = len(v) > 1 and v[1]["pad_weight"]` (no `is None` check).
@tazlin tazlin merged commit cd9497b into main Oct 3, 2024
3 checks passed
@tazlin tazlin deleted the comfyui-3bb4dec branch October 3, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant