AirBrushTool: attempting to get a smoother, better performing Airbrush #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only calculate 1/4 of the brush and draw 4 pixels at once - use LINEAR_INTERPOLATION in the CoordinateReader to get a smoother line - adjusted linear interpolation to only get 1/10th of the coordinates - remove snooze - changed FreeLineTool to NO_INTERPOLATION; it doesn't need interpolation
|
Nice. With this change it's again as fast as before! |
dsizzle
force-pushed
the
airbrush-test
branch
from
cbf12c9 to
b39e1b0
Compare
|
Ok, I cleaned up the change a bit - please re-test and if it still behaves well I can merge it. EDIT: also I changed LINEAR_INTERPOLATION to NO_INTERPOLATION for the Free Line tool. It doesn't need the interpolation and it was showing slowness with large brushes. |
|
Still perfect. Good change! |
|
merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@humdingerb can you give this a try to see if it's a better Airbrush experience? It works a lot better on my end but I'm also not seeing what you're seeing, so this is just a more general attempt to improve the Airbrush feeling.