"Storage" directory is working. #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waddlesplash
reviewed
Oct 8, 2023
| @@ -0,0 +1,476 @@ | |||
| // -*- C++ -*- | |||
|
|
|||
| // Copyright (C) 2007-2023 Free Software Foundation, Inc. | |||
There was a problem hiding this comment.
We should not need to import this file. If it's included directly, try including <algorithm> instead.
korli
reviewed
Oct 9, 2023
| @@ -6,7 +6,7 @@ | |||
| #ifndef _FSPROTO_H | |||
| #define _FSPROTO_H | |||
|
|
|||
| #include <sys/dirent.h> | |||
| #include <posix/dirent.h> | |||
There was a problem hiding this comment.
Suggested change
| #include <posix/dirent.h> | |
| #include <dirent.h> |
korli
reviewed
Oct 9, 2023
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| #include <Window.h> | |||
| #include <Messenger.h> | |||
| #include <TextControl.h> | |||
There was a problem hiding this comment.
Suggested change
| #include <TextControl.h> | |
| class BTextControl; |
korli
reviewed
Oct 9, 2023
| @@ -13,6 +13,8 @@ | |||
| #ifndef PEOPLEVIEW_H | |||
| #define PEOPLEVIEW_H | |||
|
|
|||
| #include <PopUpMenu.h> | |||
There was a problem hiding this comment.
Suggested change
| #include <PopUpMenu.h> | |
| class BPopUpMenu; |
korli
reviewed
Oct 9, 2023
Comment on lines
+12
to
+13
| #include <StringItem.h> | ||
| #include <TextView.h> |
There was a problem hiding this comment.
Suggested change
| #include <StringItem.h> | |
| #include <TextView.h> | |
| class BTextView; |
korli
reviewed
Oct 9, 2023
Comment on lines
+21
to
+22
| #include <Menu.h> | ||
| #include <FilePanel.h> |
There was a problem hiding this comment.
Suggested change
| #include <Menu.h> | |
| #include <FilePanel.h> | |
| class BMenu; | |
| class BFilePanel; |
korli
reviewed
Oct 9, 2023
| @@ -15,6 +15,7 @@ | |||
| // frame window would in MFC, i.e. cascade/tiled window arrangement. | |||
|
|
|||
| #include <Application.h> | |||
| #include <FilePanel.h> | |||
There was a problem hiding this comment.
Suggested change
| #include <FilePanel.h> | |
| class BFilePanel; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiled "storage", "portability", "intro" and "modules".