-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added A sub-menu to change the types of Font and Font-Styles #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please use the haiku coding style, as does the rest of the code. There's haiku-format in HaikuDepot that can help with that. I commented a few things, but there are more violations. Also remove additionally inserted newlines.
- The current font menu items aren't checkmarked.
- The replicated view doesn't show the text with the set font.
- Please squash related commits before submitting a PR.
Before performing the code-style cleanup, I'll read up the haiku coding style completely. Would perform the clean up soon enough. Just to make sure, the tab style for variable declaration is to be dropped everywhere (even in header files) or just inside this file? The stuff that I mentioned that is still remaining to be fixed are namely these two -
I had planned to keep working upon these issues after this PR gets merged, and to mention these 2 as separate issues so that, in case I am incapable of making it work, someone else can take up the work later. Would that be okay? |
Just in the cpp file you changed.
I suppose so. |
Requested changes have been mostly fixed. Will be keeping my out for more code-style fixes while I keep working upon this further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have another look at the coding style at https://www.haiku-os.org/development/coding-guidelines . As mentioned, "haiku-format" from HaikuDepot can help you.
- Curly brackets at the end of "switch" statements
- Same for "for" and "if" conditions
- Space after "for", "if" etc.
- Space around operators ( =, >= etc)
Manual code-style-fixes performed and .haiku-format added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better. :)
Please remove the haiku.format file. It's only needed somewhere in the folder tree when executing the haiku-format tool.
There are quite a few stray whitespaces around. I recommend installing Koder and "Highlight trailing whitespaces" in its settings. Then they are easily to spot. Maybe even try "Trim trailing whitespaces" from its "Edit" menu.
Changes performed :-
BTW, I had a query -> How did the Haiku developers settle on this codestyle (If this is not the right place to ask stuff like this, do tell me where I can do that)(IRC maybe) |
Well, when many people work on a large project for a long time, there needs to be a style guide. The main developers agreed upon the rules very quickly and it changed only very little after that. While the HaikuArchives projects aren't strictly held to these style rules, it is a huge advantage to try have everyone adopt it. Makes it easy to contribute to any project without having to relearn a new style, or god-forbid,everyone doing their own thing and the code becoming a huge smorgasbord of styles... I'll merge this for now. If it turns out you can't continue working on the open issues, and nobody else does, we can revert the changes. In the future, please use a feature branch and squash your commits to sensible code bites. |
A Menu has been added into the already existing context menu listing various font-families and font-styles that can be used in the note. This caters to #8 and partially to #9 . A few fixes still need to be carried out (would probably be working upon that shortly) .