telnet: use NCM configfs function for USB network if available #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peat-psuwit
reviewed
Oct 22, 2025
|
|
||
| if [ -z "$NETWORK_FUNCTION" ]; then | ||
| echo "Error: No USB network gadget function available" >&2 | ||
| exit 1 |
There was a problem hiding this comment.
I'm not sure exit 1 here is the best thing to do. If I understand correctly, this will exit PID 1, leading to kernel panic immediately (followed by reboot, maybe).
I think we should to the same as the # Unable to set up USB interface? Reboot. below (i.e. sleep for 60 seconds, then reboot).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed on newer device as they now have NCM enabled in kernel config by default, but not RNDIS (which is now deprecated).