Open
Conversation
The pattern of
```python
file = open("path", "r")
# ... do stuff with file ...
file.close()
```
Is subtly flawed in that if an error happens between opening the file and closing it, you will never reach the line that closes the file. This doesn't matter if the next thing your code does is crash entirely, but if you have a longer running app (like a web server) then this would be a "resource leak"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pattern of
Is subtly flawed in that if an error happens between opening the file and closing it, you will never reach the line that closes the file. This doesn't matter if the next thing your code does is crash entirely, but if you have a longer running app (like a web server) then this would be a "resource leak"
When you do
Then no matter what happens, Python will close the file when you exit that block