Start receiving from queue only once we got all inflight executions. (t…

…hought-machine#269)

* Receive from queue after getting list of jobs.

ChangeLog

@@ -1,3 +1,8 @@
+Version 11.6.3
+--------------
+    * Start receiving from queue only once we got all inflight executions.
+      This should fix a potential data race on init.
+
 Version 11.6.2
 --------------
     * Error token bucket was mistakenly consuming with `Allow()`. Refactored to make token bucket behaviour correct.

VERSION

@@ -1 +1 @@
-11.6.2
+11.6.3

mettle/api/api.go

@@ -169,7 +169,6 @@ func serve(opts grpcutil.Opts, name string, queueOpts PubSubOpts, apiURL string,
 		log.Notice("    %s: %s", k, strings.Join(v, ", "))
 	}
 
-	go srv.Receive()
 	if jobs, err := getExecutions(opts, apiURL, connTLS); err != nil {
 		log.Warningf("Failed to get inflight executions: %s", err)
 	} else if len(jobs) > 0 {
@@ -180,6 +179,7 @@ func serve(opts grpcutil.Opts, name string, queueOpts PubSubOpts, apiURL string,
 			go srv.expireJob(id)
 		}
 	}
+	go srv.Receive()
 
 	lis, s := grpcutil.NewServer(opts)
 	pb.RegisterCapabilitiesServer(s, srv)