Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blockAlert documentation #3484

Merged
merged 1 commit into from
May 8, 2023
Merged

Fix blockAlert documentation #3484

merged 1 commit into from
May 8, 2023

Conversation

obecker
Copy link
Contributor

@obecker obecker commented May 6, 2023

Change the style parameter in the example from "NSCriticalAlertStyle" to "critical". Also, according to the implementation (line 636), the default style will be "warning", not "informational".

Change the style parameter in the example from "NSCriticalAlertStyle" to "critical".
Also, according to the implementation (line 636), the default style will be "warning", not "informational".
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']

@obecker
Copy link
Contributor Author

obecker commented May 8, 2023

@cmsj @asmagill Hi, could you have a look please? Thanks

@cmsj cmsj merged commit 8ea7d10 into Hammerspoon:master May 8, 2023
@cmsj
Copy link
Member

cmsj commented May 8, 2023

lgtm, thanks!

@cmsj cmsj added the pr-change Pull Request changing behaviour label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change Pull Request changing behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants