Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAN 98: Refactor #27

Merged
merged 14 commits into from
May 1, 2024
Merged

HAN 98: Refactor #27

merged 14 commits into from
May 1, 2024

Conversation

violetaperezandrade
Copy link
Contributor

Linked ticket in Jira

Describe your changes, marking the new features and possible risks

Media: upload photos or videos (if needed)

@violetaperezandrade violetaperezandrade temporarily deployed to measurements-hanagotchi April 29, 2024 21:58 Inactive
@violetaperezandrade violetaperezandrade temporarily deployed to measurements-hanagotchi April 30, 2024 04:55 Inactive
@violetaperezandrade violetaperezandrade temporarily deployed to measurements-hanagotchi April 30, 2024 05:01 Inactive
@violetaperezandrade violetaperezandrade temporarily deployed to measurements-hanagotchi April 30, 2024 05:05 Inactive
@violetaperezandrade
address pr comment:
64b4c8c 
-refactor endpoints
+ fid Dockerfile
@violetaperezandrade violetaperezandrade temporarily deployed to measurements-hanagotchi April 30, 2024 20:34 Inactive
Agustinefe
Agustinefe requested changes Apr 30, 2024
View reviewed changes
Copy link
Member

@Agustinefe Agustinefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esto es lo unico que note que no funciona adecuadamente. El resto de los endpoints me funcionan bien tanto en postman como en la app

app/controller/measurements.py Show resolved Hide resolved
@Agustinefe
Copy link
Member

Juro que es lo ultimo ajsjkajsak 🙏

@violetaperezandrade
address PR comment:
915fa45 
-fix delete endpoint response
@violetaperezandrade violetaperezandrade temporarily deployed to measurements-hanagotchi April 30, 2024 20:55 Inactive
Agustinefe
Agustinefe approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@Agustinefe Agustinefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Dejo constancia de un arreglo para el futuro: El endpoint de get device-plants tiene un limit default de 10. Esto limita la cantidad de device-plants al obtener plantas para, por ejemplo, determinar cuales son de un usuario.

@violetaperezandrade violetaperezandrade merged commit 7e1972e into main May 1, 2024
1 check passed
@violetaperezandrade violetaperezandrade deleted the HAN-98 branch May 1, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agustinefe Agustinefe Agustinefe approved these changes

@feijooso feijooso feijooso approved these changes

@fjpacheco fjpacheco Awaiting requested review from fjpacheco

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@violetaperezandrade @Agustinefe @feijooso