Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug en el calculo de desvio de luz #33

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Bug en el calculo de desvio de luz #33

merged 5 commits into from
Jul 24, 2024

Conversation

Agustinefe
Copy link
Member

Describe your changes, marking the new features and possible risks

  • Se arregla un problema en la funcion que calculaba los rangos a evaluar para las desviaciones. Antes si tenias "2-4", te devolvia [2, 4], cuando debia devolver [2, 3, 4].
  • Se agregaron algunos tests del modulo de rule_parser.

@Agustinefe Agustinefe self-assigned this Jul 24, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 94.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Agustinefe Agustinefe merged commit d979309 into main Jul 24, 2024
3 checks passed
@Agustinefe Agustinefe deleted the issue/light-deviation-bug branch July 24, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjpacheco fjpacheco fjpacheco approved these changes

@feijooso feijooso Awaiting requested review from feijooso

@violetaperezandrade violetaperezandrade Awaiting requested review from violetaperezandrade

Assignees

@Agustinefe Agustinefe

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Agustinefe @fjpacheco