Hotfix status: rollback, return status field in get users endpoint (#26)

rollback, return status field in get users endpoint
Hanagotchi · May 31, 2024 · dd7c80d · dd7c80d
1 parent 4134552
commit dd7c80d
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/app/controller/Users.py b/app/controller/Users.py
@@ -1,4 +1,4 @@
-from fastapi import status, Response
+from fastapi import status
 from fastapi.encoders import jsonable_encoder
 from fastapi.responses import JSONResponse
 from external.Social import SocialService
@@ -25,9 +25,17 @@ def handle_get_users(self, query_params: dict):
             return JSONResponse(
                 status_code=status.HTTP_200_OK,
                 content=jsonable_encoder({
-                    "message": users})
+                    "message": users,
+                    "status": status.HTTP_200_OK,
+                    })
+                )
+        return JSONResponse(
+                status_code=status.HTTP_204_OK,
+                content=jsonable_encoder({
+                    "message": "no users found",
+                    "status": status.HTTP_204_OK,
+                    })
                 )
-        return Response(status_code=status.HTTP_204_NO_CONTENT)
 
     async def handle_create_user(self, user_data: dict):
         result = self.users_service.create_user(user_data)