Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HAN-91]: utilidades #12

Merged
merged 8 commits into from
Apr 21, 2024
Merged

[HAN-91]: utilidades #12

merged 8 commits into from
Apr 21, 2024

Conversation

fjpacheco
Copy link
Member

@fjpacheco fjpacheco commented Apr 19, 2024

Linked ticket in Jira

Describe your changes, marking the new features and possible risks

  • El endpoint POST /login ahora crea también un socialUser en el microservicio de red social mediante POST /social/users, con solamente su ID.
  • El endpoint de GET /users para obtener todos los usuarios ahora puede filtrar dada una lista de ids de usuarios mediante query param. Por ejemplo:
curl -X 'GET' \
  'http://localhost:8082/users?ids=1,2,3' \
  -H 'accept: application/json' 

Me excede

  • Me fue imposible formatear el código con max-line-length = 78.

@fjpacheco fjpacheco changed the title [HAN-91-EXTRA] [HAN-91]: extras! Apr 19, 2024
@fjpacheco fjpacheco changed the title [HAN-91]: extras! [HAN-91]: utilidades Apr 19, 2024
@fjpacheco fjpacheco self-assigned this Apr 19, 2024
@fjpacheco fjpacheco requested review from feijooso, violetaperezandrade and Agustinefe and removed request for feijooso and violetaperezandrade April 19, 2024 05:54
app/service/Users.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
Copy link
Contributor

@violetaperezandrade violetaperezandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🥸

@fjpacheco fjpacheco temporarily deployed to users-hanagotchi April 20, 2024 17:56 Inactive
@fjpacheco fjpacheco temporarily deployed to users-hanagotchi April 20, 2024 17:59 Inactive
@fjpacheco fjpacheco merged commit a5373d5 into master Apr 21, 2024
2 checks passed
@fjpacheco fjpacheco deleted the HAN-91 branch April 21, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants