Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore \begin and \end commands in \newcommand #3482

Merged
merged 10 commits into from
Mar 30, 2024

Conversation

PHPirates
Copy link
Collaborator

@PHPirates PHPirates commented Mar 1, 2024

Fix #3101

Summary of additions and changes

  • Lex \begin and \end in \newcommand and \providecommand as regular commands, as they are often unmatched

How to test this pull request

\newcommand{\tableMod}[0]{
    \end{multicols}
    \insertedObject
    \begin{multicols}{2}
}
  • Updated the documentation, or no update necessary
  • Added tests, or no tests necessary
  • Parser issue: \newcommand{\cmd}{$x$}

@PHPirates PHPirates added this to the Next milestone Mar 1, 2024
@PHPirates PHPirates enabled auto-merge March 30, 2024 15:06
@PHPirates PHPirates disabled auto-merge March 30, 2024 15:07
@PHPirates PHPirates enabled auto-merge March 30, 2024 15:16
@PHPirates PHPirates merged commit c98364c into master Mar 30, 2024
10 checks passed
@PHPirates PHPirates deleted the environment-in-definition branch March 30, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmatched \end{environment} in \newcommand
1 participant