-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic inputminted
support
#3541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is in the right direction! Since the list is rather long and likely to change, I think we should get it on the fly. A recent example is LatexCommandLineOptionsCache. The issue with the cache was that I did not want to block the UI when filling the cache, so it is done in the background, so the first time it does not show. Not sure if that is necessary for autocompletion.
How about hardcoding the partial list from Overleaf and then fetching the rest on the fly? That way even without pygments there will be some autofill |
Agree, a small default list as backup would be fine |
These changes will take some time. Drafting for now. |
…tminted # Conflicts: # src/nl/hannahsten/texifyidea/completion/pathcompletion/LatexPathProviderBase.kt # src/nl/hannahsten/texifyidea/lang/commands/LatexGenericRegularCommand.kt
@PHPirates I implemented it, it is blocking though but I got the parser built so it probably wouldnt be too bad to change it if you want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great for me, thanks!
Fix #3540
Right now, it has a hardcoded list, cannot find custom lexers, and does not enforce extension correctness. The per-language extensions are all in there. It could be refactored into an enum, but for future proofing I am leaving it as a class.
Let me know if I am on the right track here