Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic inputminted support #3541

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Conversation

jojo2357
Copy link
Contributor

@jojo2357 jojo2357 commented May 4, 2024

Fix #3540

Right now, it has a hardcoded list, cannot find custom lexers, and does not enforce extension correctness. The per-language extensions are all in there. It could be refactored into an enum, but for future proofing I am leaving it as a class.

Let me know if I am on the right track here

Copy link
Collaborator

@PHPirates PHPirates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is in the right direction! Since the list is rather long and likely to change, I think we should get it on the fly. A recent example is LatexCommandLineOptionsCache. The issue with the cache was that I did not want to block the UI when filling the cache, so it is done in the background, so the first time it does not show. Not sure if that is necessary for autocompletion.

@jojo2357
Copy link
Contributor Author

jojo2357 commented May 6, 2024

How about hardcoding the partial list from Overleaf and then fetching the rest on the fly? That way even without pygments there will be some autofill

@PHPirates
Copy link
Collaborator

Agree, a small default list as backup would be fine

@jojo2357
Copy link
Contributor Author

These changes will take some time. Drafting for now.

@jojo2357 jojo2357 marked this pull request as draft May 25, 2024 22:28
jojo2357 added 3 commits July 26, 2024 21:56
…tminted

# Conflicts:
#	src/nl/hannahsten/texifyidea/completion/pathcompletion/LatexPathProviderBase.kt
#	src/nl/hannahsten/texifyidea/lang/commands/LatexGenericRegularCommand.kt
@jojo2357
Copy link
Contributor Author

@PHPirates I implemented it, it is blocking though but I got the parser built so it probably wouldnt be too bad to change it if you want

@jojo2357 jojo2357 marked this pull request as ready for review July 27, 2024 05:31
@jojo2357 jojo2357 requested a review from PHPirates July 27, 2024 20:22
Copy link
Collaborator

@PHPirates PHPirates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me, thanks!

@PHPirates PHPirates enabled auto-merge July 29, 2024 07:18
@PHPirates PHPirates added this to the Next milestone Jul 29, 2024
@PHPirates PHPirates merged commit 88f88fa into Hannah-Sten:master Jul 29, 2024
9 checks passed
@jojo2357 jojo2357 deleted the inputminted branch July 31, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support inputminted
2 participants