Add diffcoeff and upgreek packages to command completion #3735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toseflo
requested review from
HannahSchellekens,
stenwessel,
PHPirates and
slideclimb
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
PHPirates
requested changes
Nov 9, 2024
src/nl/hannahsten/texifyidea/lang/commands/LatexUpgreekCommand.kt
Outdated
Show resolved
Hide resolved
src/nl/hannahsten/texifyidea/lang/commands/LatexDiffcoeffCommand.kt
Outdated
Show resolved
Hide resolved
src/nl/hannahsten/texifyidea/lang/commands/LatexDiffcoeffCommand.kt
Outdated
Show resolved
Hide resolved
PHPirates
reviewed
Nov 10, 2024
PHPirates
reviewed
Nov 10, 2024
src/nl/hannahsten/texifyidea/lang/commands/LatexDiffcoeffCommand.kt
Outdated
Show resolved
Hide resolved
PHPirates
reviewed
Nov 10, 2024
src/nl/hannahsten/texifyidea/lang/commands/LatexDiffcoeffCommand.kt
Outdated
Show resolved
Hide resolved
|
Almost there :) just a few comments by Qodana and then should be good to go |
PHPirates
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two new files for the diffcoeff and upgreek commands, as I use them regularly and would like to have command completion for them.
I'm not sure if I have to add something for handling of the commands or add something else. Please tell me if something is missing.
Also, I'm not quite sure what the collapse parameter does. I copied most of the upgreek file from LatexGreekCommand.kt, and it had collapse = true in every line. I don't know if it should stay there for upgreek or if I should remove it.