Feature/contact us backend : backend apis implemented for contact us form along with admin management page. #106

nikhil-3210 · 2026-01-21T01:18:32Z

Overview

The Contact Us feature provides a public submission endpoint and an admin-only management workflow.
It stores submissions, notes and history in the database and exposes CRUD APIs for admins.
Admin authorization is enforced using the existing user table and admin role.

Admin Page (Frontend)

URL: http://localhost:3000/admin/contact-submissions
Purpose: Admin-only page to review submissions, update status/priority, assign to self add internal notes, view history and delete entries.

API Endpoints (Base: `/v1`)

Total endpoints: 8

Public:

POST /contact — Create a new Contact Us submission.

Admin-only (requires admin role):

GET /contact/submissions — List all submissions.
GET /contact/submissions/{submission_id} — Get a single submission by ID.
PATCH /contact/submissions/{submission_id} — Update status/priority/assignment/resolved_at.
DELETE /contact/submissions/{submission_id} — Delete a submission.
GET /contact/submissions/{submission_id}/notes — List notes for a submission.
POST /contact/submissions/{submission_id}/notes — Add a note (internal or external).
GET /contact/submissions/{submission_id}/history — List audit history for a submission.

Tables:

contact_submissions
- id (UUID, PK)
- first_name, last_name, email (required)
- phone, company, source, ip_address (optional)
- subject, message (required)
- status (default: new)
- priority (default: medium)
- assigned_to (FK → user.id)
- created_at, updated_at, resolved_at
submission_notes
- id (UUID, PK)
- submission_id (FK → contact_submissions.id)
- admin_user_id (FK → user.id)
- note
- is_internal (default: true)
- created_at, updated_at
submission_history
- id (UUID, PK)
- submission_id (FK → contact_submissions.id)
- admin_user_id (FK → user.id)
- action, field_name, old_value, new_value
- created_at

Startup Behavior

On app startup, table creation is triggered with Base.metadata.create_all to ensure the Contact Us tables exist.

contact us public page

contact us database entried

admin only page.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 077defd434

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-21T01:29:25Z

backend-api/app/main.py

+    @app.on_event("startup")
+    async def init_contact_schema() -> None:
+        async with engine.begin() as conn:
+            await conn.run_sync(Base.metadata.create_all)


Avoid runtime DDL on every app startup

This startup hook runs Base.metadata.create_all for every process start, which executes DDL for all models. In environments where the API role is DML‑only (common when migrations are applied out‑of‑band), this will raise a permission error and prevent the service from starting, and the contact tables will never be created because no migration is included in this commit. Consider shipping an Alembic migration for the contact tables and removing (or gating) the runtime create_all to dev‑only scenarios.

Useful? React with 👍 / 👎.

this is addressed in new commit

romil-bijarnia · 2026-01-21T13:36:58Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c0aaea622

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-21T13:46:59Z

backend-api/app/api/v1/contact.py

+    if "status" in payload.__fields_set__:
+        track_change("status", submission.status, payload.status)
+        submission.status = payload.status
+        if payload.status and payload.status.lower() == "resolved" and payload.resolved_at is None:


Reject null status/priority updates

Because ContactSubmissionUpdate allows status/priority to be null, this code assigns the payload directly when the field is present. If a client sends { "status": null } (or { "priority": null } in the block just below), SQLAlchemy will try to persist NULL into columns that are nullable=False in backend-api/alembic/versions/j1k2l3m4n567_add_contact_us_tables.py, which will raise an integrity error and return a 500 instead of a 4xx. Consider validating non-null values when these fields are provided or ignoring explicit nulls.

Useful? React with 👍 / 👎.

backend-api/app/api/v1/contact.py

…y updates review addressed

nikhil-3210 · 2026-01-22T06:27:45Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a6cc080170

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

frontend/src/pages/Admin/ContactAdminPage.jsx

nikhil-3210 · 2026-01-22T06:51:24Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d94511ed9e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

backend-api/app/api/v1/contact.py

frontend/src/pages/Admin/ContactAdminPage.jsx

nikhil-3210 · 2026-01-22T07:08:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd37874ac2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

frontend/src/pages/Admin/ContactAdminPage.jsx

backend-api/app/schemas/contact.py

nikhil-3210 · 2026-01-22T08:23:20Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 244fcd6595

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-22T08:29:26Z

frontend/src/pages/Admin/ContactAdminPage.jsx

+        if (currentId !== selectedId) {
+          return;
+        }
+        setNotes(noteData);
+        setHistory(historyData);


Prevent stale detail updates from earlier requests

When admins click between submissions quickly, this guard won’t actually prevent the older request from overwriting notes/history for the newly selected submission. In this effect, currentId is assigned from selectedId in the same render, so currentId !== selectedId will never be true, and a slower response can still update state for the wrong submission. This shows up as notes/history mismatching the selected item; using a ref/abort controller or comparing against the latest selection would avoid stale updates.

Useful? React with 👍 / 👎.

nikhil-3210 · 2026-01-22T08:38:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5363070c1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-22T08:44:41Z

backend-api/app/api/v1/contact.py

+    if "status" in payload.__fields_set__:
+        if payload.status is None:
+            raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail="status cannot be null")
+        track_change("status", submission.status, payload.status)
+        submission.status = payload.status
+        if payload.status.lower() == "resolved" and submission.resolved_at is None:
+            submission.resolved_at = datetime.utcnow()


Update resolved_at when re-resolving submissions

When the status is changed to resolved, resolved_at is only set if it is currently None. If a submission is reopened (status moved to in_progress/closed) and later resolved again, the timestamp stays at the original value, so reports/SLA metrics will show an outdated resolution time. This only happens after a submission is resolved once and later re-resolved. Consider resetting resolved_at when status moves away from resolved and/or always updating it when status becomes resolved.

Useful? React with 👍 / 👎.

nikhil-3210 · 2026-01-22T10:33:08Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fcfd0a7569

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-22T10:35:47Z

backend-api/app/api/v1/contact.py

+    if "status" in payload.__fields_set__:
+        if payload.status is None:


Replace deprecated fields_set with v2 API

With pydantic>=2.11.7 (see backend-api/pyproject.toml), BaseModel no longer exposes __fields_set__; the correct accessor is model_fields_set (or use payload.model_dump(exclude_unset=True) to drive updates). As written, this line will raise AttributeError on any PATCH request, causing /v1/contact/submissions/{id} to 500 instead of applying updates. This only manifests when the update endpoint is called under the Pydantic v2 runtime.

Useful? React with 👍 / 👎.

nikhil-3210 · 2026-01-22T10:50:12Z

@codex review

chatgpt-codex-connector · 2026-01-22T10:55:41Z

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

romil-bijarnia

Hey Nikhil, Thanks for pushing these changes. The backend changes look all good to me and it is nice to have this functionality intact, would you please be able to make some changes in terms of the UI aspect of things. I feel the ContactAdminPage.jsx can be designed better, I have highlighted some inconsitencies I stopped in the screenshot you added :

I'd appreciate if you could address the ui changes and then upload another screenshot.

nikhil-3210 · 2026-01-23T07:43:23Z

@codex review

chatgpt-codex-connector · 2026-01-23T07:51:21Z

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

nikhil-3210 · 2026-01-23T07:53:07Z

Hi @romil-bijarnia

i have updated the design which is more easy to read and operate. please review it.

romil-bijarnia · 2026-01-24T12:00:43Z

Hello @nikhil-3210 , these changes look alright. Could you remove the refresh icon for me as we may not need that. Also there are a lot of emojis used in the UI, we should refrain from using them and should keep using symbols like we have for the rest of the website

nikhil-3210 · 2026-01-25T07:49:38Z

@codex review

chatgpt-codex-connector · 2026-01-25T07:56:26Z

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

romil-bijarnia · 2026-01-25T15:13:08Z

Hi @nikhil-3210 — requesting changes before merge. I reviewed the PR code + tested the UI.

Contact form is triggering native browser validation tooltips (yellow popups).
In frontend/src/pages/Contact/components/ContactForm.jsx, the form uses required fields and type="email" (and a required <select>). When the user presses Enter / submits with missing fields or an incomplete email, the browser blocks submission and shows the native tooltip UI. We shouldn’t ship browser-native validation popups.
Please disable native HTML validation UI (e.g., add noValidate on the <form> and handle validation via our own inline errors). You already have an error state — use that for required field/email validation feedback instead of the browser tooltips.

White dropdown menus in dark theme.
In frontend/src/pages/Admin/ContactAdminPage.jsx (Status/Priority) and in the contact form (Subject), we’re using native <select>. On Chrome/macOS the dropdown menu renders as a bright white system menu, which looks broken in our dark UI. Native select dropdown panels are not reliably themeable via CSS.
Please address this properly: either implement a themed/custom select component so the dropdown matches the app, or apply an approach that is confirmed to render correctly in dark mode on macOS/Chrome. But right now it needs a fix — please test it on macOS.

Admin success banner never clears.
In frontend/src/pages/Admin/ContactAdminPage.jsx, actionMessage is set (e.g., “Note added.”) and displayed, but never auto-dismisses, so the green banner stays permanently until another action happens. Please auto-clear it after a few seconds or add a dismiss action. Also consider clearing error on successful actions so old errors don’t linger.

After fixes, please re-test end-to-end and attach screenshots/GIFs showing:

Contact form submission with our inline validation (no yellow browser tooltips).
Status/Priority dropdown menu matching the dark theme (not white system dropdown).
“Note added.” message dismissing/clearing correctly.

du-dhartley · 2026-01-28T05:07:05Z

@nikhil-3210 How are the requested changes progressing? Any issues?

nikhil-3210 · 2026-01-28T07:53:03Z

@du-dhartley, working on requested changes. it should be done by tomorrow evening.

romil-bijarnia · 2026-01-28T09:29:50Z

Hey @nikhil-3210 — I checked the PR. On the admin page (frontend/src/pages/Admin/ContactAdminPage.jsx), the Status and Priority controls are implemented as native HTML select elements.

Because of that, the opened dropdown menu is rendered by the browser/OS (not fully by our CSS/theme). On some setups (e.g., Chrome/macOS), it shows up as a white popup even if the closed control is styled dark. So there won’t be a console “error”, and you might not reproduce it depending on your browser/OS/theme settings.

I'd appreciate it if you could use the existing pattern for the select components being used in the ui. Please refer to the evidence scanner page and you can see the current styling for the dropdown:

I believe this is the styling class: (In Evidence.css)

form-select,
.form-input,
.form-file {
width: 100%;
padding: 12px 14px;
border: 1px solid var(--border-color, #334155);
border-radius: 10px;
font-size: 15px;
background: var(--bg-primary, #0f172a);
color: var(--text-primary);
transition: all 0.3s ease;

nikhil-3210 · 2026-01-29T07:45:17Z

@codex review

chatgpt-codex-connector · 2026-01-29T07:55:52Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

nikhil-3210 · 2026-01-29T08:13:19Z

Hi @romil-bijarnia — thanks for the detailed review. I’ve addressed all the requested changes:

Contact form: Disabled native HTML validation (noValidate) and implemented inline validation using the existing error state (no yellow browser tooltips now).

Select dropdowns: Updated Subject (Contact form) and Status/Priority (Admin page) to use the existing themed select pattern so the dropdown matches the dark theme (tested on Chrome/macOS).

Admin success banner: actionMessage now auto-clears after 5 seconds (and I also clear old errors on successful actions so they don’t linger).

after 5 sec

romil-bijarnia

Thanks for addressing the feedback

nikhil-3210 added 3 commits January 8, 2026 18:56

contact us schemas and apis added

2196965

main branch merged and conflic resolved

2a32b9d

older api flow and schemas diagram removed

077defd

nikhil-3210 requested review from du-dhartley and romil-bijarnia as code owners January 21, 2026 01:18

chatgpt-codex-connector bot reviewed Jan 21, 2026

View reviewed changes

Avoid runtime DDL on every app startup issue addressed

2c0aaea

chatgpt-codex-connector bot reviewed Jan 21, 2026

View reviewed changes

Validate assigned_to before persisting and Reject null status/priorit…

a6cc080

…y updates review addressed

chatgpt-codex-connector bot reviewed Jan 22, 2026

View reviewed changes

frontend/src/pages/Admin/ContactAdminPage.jsx Show resolved Hide resolved

Refresh history after updates review addressed

d94511e

chatgpt-codex-connector bot reviewed Jan 22, 2026

View reviewed changes

backend-api/app/api/v1/contact.py Show resolved Hide resolved

frontend/src/pages/Admin/ContactAdminPage.jsx Show resolved Hide resolved

note refresh review addressed

bd37874

chatgpt-codex-connector bot reviewed Jan 22, 2026

View reviewed changes

frontend/src/pages/Admin/ContactAdminPage.jsx Show resolved Hide resolved

backend-api/app/schemas/contact.py Outdated Show resolved Hide resolved

review addressed

244fcd6

chatgpt-codex-connector bot reviewed Jan 22, 2026

View reviewed changes

review addressed

c536307

chatgpt-codex-connector bot reviewed Jan 22, 2026

View reviewed changes

review addressed

fcfd0a7

chatgpt-codex-connector bot reviewed Jan 22, 2026

View reviewed changes

review addressed

abb97f4

romil-bijarnia requested changes Jan 22, 2026

View reviewed changes

admin page for contact us form details is updated

0c3b699

refresh icon removed, emojis removed

1642f33

nikhil-3210 added 3 commits January 29, 2026 18:32

drop down menu design aligned with project theme

c6710b0

Admin success banner for note clears in 5 sec

9d03231

exsiting error state used for showing error on contact us form

9b5a087

romil-bijarnia self-requested a review January 29, 2026 12:05

romil-bijarnia approved these changes Jan 29, 2026

View reviewed changes

romil-bijarnia merged commit 85829f0 into main Jan 29, 2026
16 of 17 checks passed

romil-bijarnia deleted the feature/contact-us-backend branch February 2, 2026 17:01

		if "status" in payload.__fields_set__:
		if payload.status is None:

Feature/contact us backend : backend apis implemented for contact us form along with admin management page. #106

Feature/contact us backend : backend apis implemented for contact us form along with admin management page. #106

Uh oh!

Conversation

nikhil-3210 commented Jan 21, 2026

Overview

Admin Page (Frontend)

API Endpoints (Base: /v1)

Startup Behavior

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

nikhil-3210 Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

romil-bijarnia commented Jan 21, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nikhil-3210 commented Jan 22, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

nikhil-3210 commented Jan 22, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

nikhil-3210 commented Jan 22, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

nikhil-3210 commented Jan 22, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

nikhil-3210 commented Jan 22, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

nikhil-3210 commented Jan 22, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

API Endpoints (Base: `/v1`)

romil-bijarnia commented Jan 28, 2026 •

edited

Loading