Skip to content

Gcp/service/bigquery #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Miguwell-I merged 10 commits into from
Feb 1, 2026
Merged

Gcp/service/bigquery #260

Miguwell-I merged 10 commits into from
Feb 1, 2026

Conversation

@Miguwell-I
Copy link
Contributor

@Miguwell-I Miguwell-I commented Jan 7, 2026

Created Policies for BigQuery

Resources used:

google_bigquery_dataset
google_bigquery_dataset_access
google_bigquery_dataset_iam
google_bigquery_job
google_bigquery_routine
google_bigquery_row_access_policy
google_bigquery_table
google_bigquery_table_iam

Total Polices: 35

@patrickandersondeakin patrickandersondeakin self-assigned this Jan 20, 2026
patrickandersondeakin
patrickandersondeakin requested changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@patrickandersondeakin patrickandersondeakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please make the requested changes.
Additionally, please generate markdown documentation. Will not approve until this has been completed.

patrickandersondeakin
patrickandersondeakin requested changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@patrickandersondeakin patrickandersondeakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi looks good, however please create your markdown documentation.

Video regarding how-to is on the upskilling guide.

Once that is done I will consider merge.

patrickandersondeakin
patrickandersondeakin requested changes Jan 25, 2026
View reviewed changes
Copy link
Contributor

@patrickandersondeakin patrickandersondeakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I need you to generate ALL plan.json files as without these your policies will not pass OPA auto_test

patrickandersondeakin
patrickandersondeakin requested changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@patrickandersondeakin patrickandersondeakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey miguel, let's get these changes done and we will be ready to merge.

@patrickandersondeakin
Copy link
Contributor

patrickandersondeakin commented Jan 29, 2026

Hi Miguel please click Update branch, and I will greenlight for merge.

patrickandersondeakin
patrickandersondeakin approved these changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@patrickandersondeakin patrickandersondeakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merge

@Miguwell-I Miguwell-I merged commit 2279fdf into dev Feb 1, 2026
1 check failed
@Miguwell-I Miguwell-I deleted the gcp/service/Bigquery branch February 1, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickandersondeakin patrickandersondeakin patrickandersondeakin approved these changes

Assignees

@patrickandersondeakin patrickandersondeakin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Miguwell-I @patrickandersondeakin