feat: register Biometric Credentials with WebAuthn [wallet - service]#164
Open
sotoJ24 wants to merge 3 commits intoHarmonia-Development:mainfrom
Open
feat: register Biometric Credentials with WebAuthn [wallet - service]#164sotoJ24 wants to merge 3 commits intoHarmonia-Development:mainfrom
sotoJ24 wants to merge 3 commits intoHarmonia-Development:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔐 Add WebAuthn Biometric Registration API
Summary
This PR implements WebAuthn-based biometric credential registration for the Stellar wallet service, allowing users to register their biometric credentials (fingerprint, Face ID, Windows Hello) for passwordless authentication.
closes: #151
Changes Made
📁 Database Layer (
src/db/kyc.ts)credentialstable with columns:id(primary key, auto-increment)user_id(foreign key tokyc.id)credential_id(unique, stores WebAuthn credential ID)public_key(stores WebAuthn public key)CredentialRowTypeScript typeinitializeCredentialsTable()function with proper indexes🔑 WebAuthn Module (
src/auth/webauthn.ts)generateRegistrationOptions()function🛣️ API Routes (
src/routes/auth-register.ts)✅ POST
/auth/register/optionsuser_idexists in KYC table✅ POST
/auth/register/verify@simplewebauthn/serveruser_idandcredential_id✅ Error Handling
user_id🧪 Tests (
tests/routes/auth-register.test.ts)/auth/register/optionsendpoint (4 test cases)/auth/register/verifyendpoint (8 test cases)@simplewebauthn/serverand SQLite database🔧 Configuration
src/index.tsto mount auth register routespackage.jsonto use Bun native TypeScript supportDependencies Added
@simplewebauthn/server- WebAuthn verificationyn- Required by ts-node