Skip to content

issue of light/dark theme is resolved#178

Closed
JiyaBatra wants to merge 1 commit intoHarshYadav152:mainfrom
JiyaBatra:Issue/#106solved
Closed

issue of light/dark theme is resolved#178
JiyaBatra wants to merge 1 commit intoHarshYadav152:mainfrom
JiyaBatra:Issue/#106solved

Conversation

@JiyaBatra
Copy link

Description

This PR resolves the inconsistency in the light/dark theme behavior across the application.
The issue caused UI elements to not properly adapt when switching themes, leading to poor readability and an inconsistent user experience.

The theme logic has now been aligned so that all relevant components correctly respond to theme changes.

Fixes #106

Type of change

Bug fix (non-breaking change which fixes an issue)

New feature (non-breaking change which adds functionality)

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation update

How Has This Been Tested?

Manually toggled between light and dark themes

Verified UI consistency across affected components

Checked text visibility, background colors, and contrast in both modes

Steps to reproduce:

Run the application locally

Toggle between light and dark mode

Observe that all UI elements update correctly without visual issues

Checklist

My code follows the style guidelines of this project

I have performed a self-review of my own code

I have commented my code, particularly in hard-to-understand areas

I have made corresponding changes to the documentation

My changes generate no new warnings

I have added tests that prove my fix is effective or that my feature works

New and existing unit tests pass locally with my changes

screenrec:

Uploading SaveBook _ Your Personal Notebook & Cloud Note-Taking App - Google Chrome 2026-01-28 09-51-42.mp4…

@vercel
Copy link

vercel bot commented Jan 28, 2026

@JiyaBatra is attempting to deploy a commit to the Harsh Yadav's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@HarshYadav152 HarshYadav152 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JiyaBatra
Light/Dark theme is not properly reflected to some pages like /login, /register, /notes and some area of /
Footer.

@HarshYadav152
Copy link
Owner

@JiyaBatra What is the progress?

@JiyaBatra
Copy link
Author

@JiyaBatra What is the progress?

I was just working on this, and since I’m not very familiar with Tailwind CSS, I’m keeping it simple for now. Please give me some time.

@JiyaBatra
Copy link
Author

@HarshYadav152 I’ll try to complete the work on this issue by tomorrow. If it’s not done by tonight, I’ll go ahead and close the issue myself.

@JiyaBatra
Copy link
Author

@HarshYadav152 I tried my best and have been working on this for 2 hours, but it’s still not working. Sorry for the inconvenience.

@HarshYadav152
Copy link
Owner

Stuck anywhere reach out to us https://chat.whatsapp.com/I8GYXd3mHlDCC2iXhNGeqV

@HarshYadav152
Copy link
Owner

Stuck anywhere reach out to us https://chat.whatsapp.com/I8GYXd3mHlDCC2iXhNGeqV

For immediate response

@VinayKumar42
Copy link
Collaborator

@JiyaBatra what the progess?
And let me know as soon as possible

@HarshYadav152
Copy link
Owner

@JiyaBatra This PR will be closed,
You are welcome to reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Light/Dark Mode Toggle with Optimized Viewport Coverage and Readability.

3 participants