Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: added 'add topic' page for student #342

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

trinetra110
Copy link
Contributor

📋 Description

Added a "add topic" page for student (frontend only) and added the link in the student's main page, keeping in mind the responsiveness across all devices.

🔨 Changes Made

  • Created new files "add_topic.html", "add_topic.css" and "add_topic.js"
  • Added the link to "add_topic.html" in "main_page.html"

✅ Checklist

Before submitting the PR, please make sure you have completed the following:

  • I have followed all the guidelines mentioned in CONTRIBUTING.md.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).
  • I have tested it locally and it works fine.
  • Any dependent changes have been merged and published in downstream modules.

🏷️ Types of Changes

What type of changes does your code introduce? (Check all that apply)

  • Bug fix (non-breaking change which fixes an issue) 🐛

  • New feature (non-breaking change which adds functionality) ✨

  • UI enhancement (non-breaking change which enhances UI) 🎨

  • Documentation update 📚

  • Fixes Add a "Add topic" page for Student #334

📸 Screenshots (if applicable)

  • Desktop/laptop

Screenshot 2024-10-30 201736

Screenshot (34)

  • Phone

Screenshot 2024-10-30 201753

  • Tab

Screenshot 2024-10-30 201806


Thank you for contributing to Research Nexus! We look forward to reviewing your PR and getting it merged!

@trinetra110
Copy link
Contributor Author

@Harshdev098 I have made the required changes. Please review it and add the 'hacktoberfest', 'hacktoberfest-accepted', 'gssoc-ext' and a 'level' tag.

@Harshdev098
Copy link
Owner

@trinetra110 Instead of students name you can make it Departments field if you can make it as option type fields it will be good like there in form-filling.html

@trinetra110
Copy link
Contributor Author

@trinetra110 Instead of students name you can make it Departments field if you can make it as option type fields it will be good like there in form-filling.html

Screenshot 2024-10-30 212434

Screenshot 2024-10-30 212451

@Harshdev098 I have made the changes. Please review and add the labels.

@Harshdev098 Harshdev098 merged commit 762d23e into Harshdev098:main Oct 30, 2024
1 check passed
Copy link
Contributor

🎉🎉 Thank you for your contribution! Your PR #342 has been merged! 🎉🎉

@Harshdev098 Harshdev098 added hacktoberfest This issue belongs to hacktoberfest gssoc-ext This issue is under GSSoc Ext program level3 labe3 label for gssoc hacktoberfest-accepted label for accepted PRs under hacktoberfest labels Oct 30, 2024
@trinetra110 trinetra110 deleted the add-topic branch October 30, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext This issue is under GSSoc Ext program hacktoberfest This issue belongs to hacktoberfest hacktoberfest-accepted label for accepted PRs under hacktoberfest level3 labe3 label for gssoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "Add topic" page for Student
2 participants