Skip to content

Commit

Permalink
Enable action.X.used_for_danse expression, fix Sub Rogue not recommen…
Browse files Browse the repository at this point in the history
…ding Secret Technique #2868
  • Loading branch information
Hekili committed Nov 8, 2023
1 parent 1729a2b commit 9460cfe
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Dragonflight/APLs/RogueSubtlety.simc
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ actions.cds+=/use_items,if=!stealthed.all&(!trinket.mirror_of_fractured_tomorrow
actions.finish+=/variable,name=secret_condition,value=(action.shadowstrike.used_for_danse|action.shuriken_storm.used_for_danse)&(action.eviscerate.used_for_danse|action.black_powder.used_for_danse|action.rupture.used_for_danse)|!talent.danse_macabre
# Apply Rupture if its not up.
actions.finish+=/rupture,if=!dot.rupture.ticking&target.time_to_die-remains>6
actions.finish+=/variable,name=premed_snd_condition,value=talent.premeditation.enabled&spell_targets.shuriken_storm<5
actions.finish+=/variable,name=premed_snd_condition,value=talent.premeditation.enabled&spell_targets.shuriken_storm<5
# Refresh Slice and Dice outside of Shadow Dance.
actions.finish+=/slice_and_dice,if=!stealthed.all&!variable.premed_snd_condition&spell_targets.shuriken_storm<6&!buff.shadow_dance.up&buff.slice_and_dice.remains<fight_remains&refreshable
# Variable to decide when not to use Rupture.
Expand Down
6 changes: 6 additions & 0 deletions Dragonflight/RogueAssassination.lua
Original file line number Diff line number Diff line change
Expand Up @@ -2323,6 +2323,12 @@ spec:RegisterAbilities( {
cycle = "rupture",

usable = function () return combo_points.current > 0, "requires combo_points" end,

used_for_danse = function()
if not state.spec.subtlety or not talent.danse_macabre.enabled or buff.shadow_dance.down then return false end
return danse_macabre_tracker.rupture
end,

handler = function ()
removeStack( "goremaws_bite" )
removeBuff( "masterful_finish" )
Expand Down
Loading

0 comments on commit 9460cfe

Please sign in to comment.