debug and deprecate python 3.8

.github/workflows/Build.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11"]
+        python-version: ["3.9", "3.10", "3.11"]
 
     # Skip CI if 'skip ci' is contained in latest commit message
     if: "!contains(github.event.head_commit.message, 'skip ci')"

setup.py

@@ -17,7 +17,7 @@ def getVersionNumber():
     author_email='minhuanli@g.harvard.edu',
     packages=find_packages(),
     include_package_data=True,
-    python_requires=">=3.8",
+    python_requires=">=3.9",
     install_requires=[
         "gemmi>=0.5.6",
         "reciprocalspaceship>=0.9.18",

tests/test_Fmodel.py

@@ -34,7 +34,7 @@ def test_constructor_SFcalculator(data_pdb, data_mtz_exp, data_cif, data_sfcif,
         bins_labels = sfcalculator.assign_resolution_bins(return_labels=True)
         assert sfcalculator.inspected
         assert np.isclose(assert_numpy(sfcalculator.solventpct), 0.1667, 1e-3)
-        assert sfcalculator.gridsize == [50, 60, 60]
+        assert sfcalculator.gridsize == [50, 64, 64]
         assert len(sfcalculator.HKL_array) == 3256
         assert len(sfcalculator.Hasu_array) == 4035
         assert len(sfcalculator.bins) == 3256