Modernization and Feature Implementation#2233
Open
ahmedtariqh wants to merge 1848 commits intoHeliBorg:masterfrom
Open
Modernization and Feature Implementation#2233ahmedtariqh wants to merge 1848 commits intoHeliBorg:masterfrom
ahmedtariqh wants to merge 1848 commits intoHeliBorg:masterfrom
Conversation
see HeliBorgGH-801 (probably does not fix the OnePlus issue)
…for a word avoids some sort of cache returning previous suggestions, see HeliBorgGH-1542
apparently this fixes HeliBorgGH-1614 (spurious crash in the native google library on Android 7) though maybe the reason is a difference between ExecutorUtils and coroutines?
especially for crashes while device is locked might help with HeliBorg#801
and rename to MoreSuggestionsView
so we update when a package is added or removed should fix HeliBorg#2023
and allow confirming the addition with the action key
there is some issue about this, not sure which...
Collaborator
|
Could you please explain the modernization plan? Not just what you want to do (that's in the md file), but why? Further please separate the modernization and the feature implementation into separate PRs (see the guidelines), and in those PRs there should be your changes and not over 1000 other commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Phase 1 and Phase 2 of the Modernization Plan.
Changes:
See progress.md for details.