Add option to toggle hardware keyboard support in settings#2251
Open
ikodbapc wants to merge 1 commit intoHeliBorg:mainfrom
Open
Add option to toggle hardware keyboard support in settings#2251ikodbapc wants to merge 1 commit intoHeliBorg:mainfrom
ikodbapc wants to merge 1 commit intoHeliBorg:mainfrom
Conversation
Helium314
reviewed
Mar 1, 2026
| ?: Event.NOT_A_CODE_POINT // KeyEvent has 0 if no codePoint, but that's actually valid so we convert it to -1 | ||
|
|
||
| // Debug logging to understand hardware keyboard behavior | ||
| val charFromEvent = if (codePointAndFlags > 0) codePointAndFlags.toChar() else '?' |
Collaborator
There was a problem hiding this comment.
This is potentially very sensitive data, there should definitely be no logging of all inputs.
Collaborator
|
Proper implemetation would be better (and save me from a bunch of issues inevitably coming up again), but alright. But please add it to the experimental section, then we don't need the |
Collaborator
|
Any reason to keep the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add toggle for hardware keyboard support
Summary
This PR adds a user-facing setting to enable/disable hardware keyboard support, replacing the hardcoded ProductionFlags.IS_HARDWARE_KEYBOARD_SUPPORTED = false flag.
Hardware keyboard support was disabled in v3.3 due to multiple issues (#1949, #1957, #2001, #2030, #2047). However, some users with physical keyboards need this functionality and are willing to accept potential issues. This change makes the feature opt-in rather than completely unavailable.
Changes
Testing
Tested with Croatian QWERTZ physical keyboard layout. Special characters (č, ć, ž, š, đ) work correctly when:
Related issues
Partially addresses #1949, #1957 by giving users the option to enable hardware keyboard support despite known issues.