Feature: vibrate for repeated inputs #381#2355
Open
glen-nicol wants to merge 1 commit intoHeliBorg:mainfrom
Open
Feature: vibrate for repeated inputs #381#2355glen-nicol wants to merge 1 commit intoHeliBorg:mainfrom
glen-nicol wants to merge 1 commit intoHeliBorg:mainfrom
Conversation
This is primarily noticeable when holding the delete key to delete multiple characters.
Collaborator
|
@devycarol you did some work on haptic feedback, and iirc have plans to do more. Do you see any issues with this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primarily noticeable when holding the delete key to delete multiple characters or when using the keyboard to move the cursor.
This implements the desired behavior of #381. It does not implement the vibrate on paste behavior mentioned further down the issue.
The change is remarkably simple. Just perform haptics on repeat key presses. It works great for delete and swipe at low and high vibration durations on my test phone (Pixel 3a). And holding other keys doesn't trigger a repeat since they have a long press handler.