Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix association properties not showing request data on async logger #3308

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kavinvalli
Copy link
Collaborator

@kavinvalli kavinvalli commented Feb 22, 2025

Due to the way OpenLLMetry is checking for "tracing enabled" or not in the set_association_properties function, the traceloop content enable/disable has to be using the global env variable. This should be fine since we were setting it to false globally before anyways.

OpenLLMetry code reference:
https://github.com/traceloop/openllmetry/blob/4c59eb3f13eaa16346965602fc893f4e00a4c98b/packages/traceloop-sdk/traceloop/sdk/tracing/tracing.py#L166-L174

https://github.com/traceloop/openllmetry/blob/4c59eb3f13eaa16346965602fc893f4e00a4c98b/packages/traceloop-sdk/traceloop/sdk/config/__init__.py#L12-L13

The __content_allow_list cannot be changed because it is automatically loading the associationPropertyAllowList which is only available if using traceloop's dashboard

Copy link

vercel bot commented Feb 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helicone ❌ Failed (Inspect) Feb 22, 2025 6:13am
helicone-bifrost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2025 6:13am
helicone-eu ❌ Failed (Inspect) Feb 22, 2025 6:13am

Copy link
Contributor

promptless bot commented Feb 22, 2025

📝 Documentation updates detected! You can review documentation updates here

Copy link

fumedev bot commented Feb 22, 2025

Summary

  • Fixes the issue where association properties were not displaying request data in the async logger.
  • Removes the use of attach(set_value("override_enable_content_tracing", True)) and attach(set_value("override_enable_content_tracing", False)).
  • Updates environment variable management for content tracing by directly setting TRACELOOP_TRACE_CONTENT to "true" or "false" in the enable_content_tracing and disable_content_tracing methods respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant