fix : Incorrect pagination when changing rows per page on Requests page#5521
Open
lokeshramchand-ctrl wants to merge 9 commits intoHelicone:mainfrom
Open
fix : Incorrect pagination when changing rows per page on Requests page#5521lokeshramchand-ctrl wants to merge 9 commits intoHelicone:mainfrom
lokeshramchand-ctrl wants to merge 9 commits intoHelicone:mainfrom
Conversation
…effect for recalculation
…leFooter component
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
@lokeshramchand-ctrl is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
@claude can you fix the merge conflicts? |
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #5475
Component/Service
Type of Change
Deployment Notes
Context
Pagination on the Requests page was not updating dynamically when users changed the "Rows per page" dropdown. Additionally, Docker builds were failing due to a missing workspace package reference.
Observed behavior:
Couldn't find package "@helicone-package/pricing@*"Root Cause
totalPageswas calculated as a static variable and did not recalculate whenpageSizechanged, preventing dynamic updates to pagination UIdockerfile_webwas missing theCOPYcommand for pricing, causing yarn dependency resolution to fail during container buildsWhat changed
COPY package.json ./packages/pricing/to ensure all workspace packages are available duringyarn installtotalPagesfrom a static variable to a state variable withuseEffectdependency array[count, pageSize]to ensure it recalculates whenever page size or record count changesThese changes are strictly UI-state related for pagination and dependency resolution improvements. No backend APIs or data behavior changes.
Screenshots / Demos
Before
After
Extra Notes