Skip to content

fix : Incorrect pagination when changing rows per page on Requests page#5521

Open
lokeshramchand-ctrl wants to merge 9 commits intoHelicone:mainfrom
lokeshramchand-ctrl:pag-lo
Open

fix : Incorrect pagination when changing rows per page on Requests page#5521
lokeshramchand-ctrl wants to merge 9 commits intoHelicone:mainfrom
lokeshramchand-ctrl:pag-lo

Conversation

@lokeshramchand-ctrl
Copy link

Ticket

Closes #5475


Component/Service

  • Web (Frontend)
  • Infrastructure/Docker
  • Jawn (Backend)
  • Worker (Proxy)
  • Bifrost (Marketing)
  • AI Gateway
  • Packages
  • Documentation

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Performance improvement
  • Refactoring

Deployment Notes

  • No special deployment steps required
  • Database migrations need to run
  • Environment variable changes required
  • Coordination with other teams needed

Context

Pagination on the Requests page was not updating dynamically when users changed the "Rows per page" dropdown. Additionally, Docker builds were failing due to a missing workspace package reference.

Observed behavior:

  • Total page count remained static when adjusting "Rows per page" dropdown (25, 50, 100, 250, 500)
  • Docker build failed with: Couldn't find package "@helicone-package/pricing@*"
  • Pagination controls did not reflect the correct page count for different page sizes

Root Cause

  1. TableFooter state issue: totalPages was calculated as a static variable and did not recalculate when pageSize changed, preventing dynamic updates to pagination UI
  2. Docker build issue: The dockerfile_web was missing the COPY command for pricing, causing yarn dependency resolution to fail during container builds

What changed

  • Docker: Added missing COPY package.json ./packages/pricing/ to ensure all workspace packages are available during yarn install
  • TableFooter: Converted totalPages from a static variable to a state variable with useEffect dependency array [count, pageSize] to ensure it recalculates whenever page size or record count changes
  • Pagination behavior: Total page count now updates correctly when users select different rows-per-page options

These changes are strictly UI-state related for pagination and dependency resolution improvements. No backend APIs or data behavior changes.


Screenshots / Demos

Before

Image
Image

  • 25 rows and 500 rows both showed the same total page count
  • Page size changes had no effect on pagination
Image
  • Navigating to the last page resulted in an empty state

After

image
image

  • Page count now correctly updates when switching between 25 / 500 rows
image
  • Last page navigation consistently shows valid data

Extra Notes

  • Frontend and Docker configuration fix
  • No backend changes
  • No schema/query modifications
  • Scoped to pagination state management and Docker build reliability

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@vercel
Copy link

vercel bot commented Jan 15, 2026

@lokeshramchand-ctrl is attempting to deploy a commit to the Helicone Team on Vercel.

A member of the Team first needs to authorize it.

@lokeshramchand-ctrl lokeshramchand-ctrl changed the title Pag lo fix : Incorrect pagination when changing rows per page on Requests page Jan 15, 2026
@chitalian
Copy link
Contributor

@claude can you fix the merge conflicts?

@claude
Copy link
Contributor

claude bot commented Jan 21, 2026

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect total request count and broken pagination after ingesting data

2 participants