Include lai #88
Include lai #88
Conversation
|
tested the sfcsub.F to read the LAI files. I reset all other changes |
| @@ -810,6 +810,7 @@ subroutine noahmpdrv_run & | |||
| soil_carbon_stable = stblcpxy(i) | |||
| soil_carbon_fast = fastcpxy(i) | |||
| leaf_area_index = xlaixy(i) | |||
| ! print '(A,F10.3)','xlaixy=',xlaixy(i) | |||
There was a problem hiding this comment.
remove these three commented prints
| @@ -1172,14 +1172,15 @@ subroutine phenology (parameters,vegtyp ,croptype, snowh , tv , lat , yea | |||
| wt2 = 1.-wt1 | |||
| if (it1 .lt. 1) it1 = 12 | |||
| if (it2 .gt. 12) it2 = 1 | |||
|
|
|||
| print '(A,F10.1)','lailsm=',lai | |||
| if(fnlaic(1:8).ne.' ') then | ||
| do i=1,len | ||
| laiclm(i) = wei1m * lai(i,k1) + wei2m * lai(i,k2) | ||
| ! print '(A,F10.1)','laiclm=',laiclm(i) |
There was a problem hiding this comment.
remove this commented print to be consistent with other similar calculations
| call fixrdc_tile(fnlaic, tile_num_ch, i_index, j_index, | ||
| & kpdlai, lai(:,nn), mon, len, me) | ||
|
|
||
| ! print *, '(A,F10.1)','laimon2=',lai(1,12) |
| ! leaf are index | ||
| ! | ||
| if (fnlaic(1:8) .ne. ' ') then | ||
| if ( index(fnlaic, "tileX.nc") == 0) then ! grib file |
There was a problem hiding this comment.
since there is no grib file, what happens here? what does the model end up with for an LAI?
There was a problem hiding this comment.
This was added to be consistent with other variables. If the dveg = 9 and an FNLAIC is defined and pointing to an existing the model will read from file. If the grib file doesn't exist , I think It should result in a file not found error. I will request @GeorgeGayno to respond/confirm please.
| else | ||
| call fixrdc_tile(fnlaic, tile_num_ch, i_index, j_index, | ||
| & kpdlai, lai(:,nn), mon, len, me) | ||
| ! print '(A,F10.1)','laimon1=',lai(1,12) |
| ! leaf area index | ||
| ! | ||
| if (fnlaic(1:8).ne.' ') then | ||
| if ( index(fnlaic, "tileX.nc") == 0) then ! grib |
| @@ -346,6 +352,10 @@ subroutine sfccycle(lugb,len,lsoil,sig1t,deltsfc & | |||
| parameter(veglmx=1.0,veglmn=0.0,vegomx=0.0,vegomn=0.0, | |||
| & vegsmx=1.0,vegsmn=0.0,vegimx=0.0,vegimn=0.0, | |||
| & vegjmx=0.0,vegjmn=0.0) | |||
| ! leaf area index | |||
| parameter(lailmx=7.0,lailmn=0.0,laiomx=7.0,laiomn=0.0, ! Sanath fix these values | |||
There was a problem hiding this comment.
in general, I wouldn't add your name in the code unless there is some precedent, e.g., in the header section
There was a problem hiding this comment.
I left that so that I can revisit and fix teh max and min values to any suggested value. As of now its an arbitrary 7 and 0
| & kpdvmn,kpdvmx,kpdslp,kpdabs | ||
| &, kpdsnd, kpdabs_0, kpdabs_1, kpdalb(4) | ||
| parameter(kpdtsf=11, kpdwet=86, kpdsno=65, kpdzor=83, | ||
| ! & kpdalb=84, kpdais=91, kpdtg3=11, kpdplr=224, | ||
| & kpdais=91, kpdtg3=11, kpdplr=224, | ||
| & kpdgla=238, kpdmxi=91, kpdscv=238, kpdsmc=144, | ||
| & kpdoro=8, kpdmsk=81, kpdstc=11, kpdacn=91, kpdveg=87, | ||
| & kpdoro=8, kpdmsk=81, kpdstc=11, kpdacn=91, | ||
| & kpdveg=87,kpdlai=181, |
There was a problem hiding this comment.
add a couple of spaces to line this up like above lines; also, why is this 181 and not 182? I see 182 as the grib number for LAI. is that what this is?
There was a problem hiding this comment.
Added spaces. Coudl you send me the link to where you saw the grib number please ?. I believe this could be a typo as i had copied this number from a hand written note from past discussions.
There was a problem hiding this comment.
| do ix=1,npts | ||
| ! print '(A,F10.1)','laiclm=',laiclm(ix) |
| @@ -855,12 +856,13 @@ subroutine noahmpdrv_run & | |||
| call transfer_mp_parameters(vegetation_category, soil_category, & | |||
| slope_category, soil_color_category, crop_type,parameters) | |||
| parameters%prcpiceden = rhonewsn1(i) | |||
| ! print *,'dveg=',idveg | |||
There was a problem hiding this comment.
it seems that some of these print removals didn't get pushed to your fork?
sanatcumar
force-pushed
the
include_lai
branch
from
be0da92 to
8a68b4b
Compare
ufs-community#209