Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add invert control #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add invert control #4

wants to merge 4 commits into from

Conversation

jamesfowkes
Copy link
Contributor

Adds control of the global output invert bit in MODE2 register. Useful when using the PCA9633 with external drivers.

HendrikVE
HendrikVE requested changes Aug 9, 2021
View reviewed changes
Copy link
Owner

@HendrikVE HendrikVE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After you fixed the name issue please do a proper rebase and squash, there are unrelated changes in the commit history (like changing readReg to public instead of private).

src/PCA9633.cpp
@@ -147,6 +147,20 @@ void PCA9633::setDrvState(uint8_t state) {
writeReg(REG_MODE2, newReg);
}

void PCA9633::setInvertState(uint8_t invert) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code does not compile because invert needs to be renamed to state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HendrikVE HendrikVE HendrikVE requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesfowkes @HendrikVE