vm_arm: define vm_create_vcpus()

Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
Hensoldt-Cyber · Jun 15, 2023 · b147a32 · b147a32
1 parent 2659357
commit b147a32
Showing 1 changed file with 41 additions and 22 deletions.
diff --git a/components/VM_Arm/src/main.c b/components/VM_Arm/src/main.c
@@ -811,6 +811,44 @@ static int route_irqs(vm_vcpu_t *vcpu, irq_server_t *irq_server)
     return 0;
 }
 
+static int vm_create_vcpus(vm_t *vm, const vm_config_t *vm_config,
+                           irq_server_t *irq_server)
+{
+    int err;
+
+    ZF_LOGI("Creating %d vCPUs", NUM_VCPUS);
+
+    /* Create CPUs and DTB node */
+    for (int i = 0; i < NUM_VCPUS; i++) {
+        vm_vcpu_t *vcpu = create_vmm_plat_vcpu(vm, VM_PRIO - 1);
+        if (!vcpu) {
+            ZF_LOGE("Failed to create VCPU %d", i);
+            return -1;
+        }
+    }
+
+    vm_vcpu_t *vcpu_boot = vm->vcpus[BOOT_VCPU];
+    if (!vcpu_boot) {
+        ZF_LOGE("BOOT_VCPU (%d) is not set up", BOOT_VCPU);
+        return -1;
+    }
+
+    err = vm_assign_vcpu_target(vcpu_boot, 0);
+    if (err) {
+        ZF_LOGE("Failed to assign boot vcpu (%d)", err);
+        return -1;
+    }
+
+    err = route_irqs(vcpu_boot, irq_server);
+    if (err) {
+        ZF_LOGE("Failed route IRQs to boot vcpu (%d)", err);
+        return -1;
+    }
+
+    return 0;
+}
+
+
 static int vm_dtb_init(vm_t *vm, const vm_config_t *vm_config)
 {
     int err;
@@ -1258,28 +1296,9 @@ static int main_continued(void)
     err = vm_create_default_irq_controller(&vm);
     assert(!err);
 
-    /* Create CPUs and DTB node */
-    for (int i = 0; i < NUM_VCPUS; i++) {
-        vm_vcpu_t *new_vcpu = create_vmm_plat_vcpu(&vm, VM_PRIO - 1);
-        assert(new_vcpu);
-    }
-    if (vm_config.generate_dtb) {
-        err = fdt_generate_plat_vcpu_node(&vm, gen_dtb_buf);
-        if (err) {
-            ZF_LOGE("Couldn't generate plat_vcpu_node (%d)", err);
-            return -1;
-        }
-    }
-
-    vm_vcpu_t *vm_vcpu = vm.vcpus[BOOT_VCPU];
-    err = vm_assign_vcpu_target(vm_vcpu, 0);
-    if (err) {
-        return -1;
-    }
-
-    /* Route IRQs */
-    err = route_irqs(vm_vcpu, _irq_server);
+    err = vm_create_vcpus(&vm, &vm_config, _irq_server);
     if (err) {
+        ZF_LOGE("Error: Failed to create VCPUs");
         return -1;
     }
 
@@ -1299,7 +1318,7 @@ static int main_continued(void)
         return -1;
     }
 
-    err = vcpu_start(vm_vcpu);
+    err = vcpu_start(vm.vcpus[BOOT_VCPU]);
     if (err) {
         ZF_LOGE("Failed to start Boot VCPU");
         return -1;