-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkwall #2282
base: master
Are you sure you want to change the base?
Checkwall #2282
Conversation
src/map/script.c
Outdated
{ | ||
const char *name = script_getstr(st, 2); | ||
|
||
if (((struct iwall_data *)strdb_get(map->iwall_db, name)) == NULL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think better use strdb_exists for check is wall present or not
Similar to #2150, except that this one has script edits |
Can you put the script edit into yours? It's necessary to stop console spam due to the delwall now sending warnings/debugs. |
it might be better to have a *getwallinfo("<name>", <info>)
Returns info on a wall created by setwall().
<info> can be:
WALLINFO_MAP map name
WALLINFO_X X axis location
WALLINFO_Y Y axis location
WALLINFO_DIR direction
WALLINFO_SHOOTABLE whether or not it's shootable And then to check if a wall exists you could do |
Dont forget |
Pull Request Prelude
Changes Proposed
checkwall()
script command, which will return if wall exists. Needed for scripts which attempt to delete non-existent walls.checkwall()
to agit_main_se script, which attempts to delete a non-existent wall when War of Emperium starts.Affected Branches:
Issues addressed:
#2119
Known Issues and TODO List
None known.