-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configuration to fullprotect skill #2331
Open
carloshenrq
wants to merge
1
commit into
HerculesWS:master
Choose a base branch
from
carloshenrq:config_fullprotect
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here you have issue with parentheses. |
dastgirp
requested changes
Nov 28, 2018
carloshenrq
force-pushed
the
config_fullprotect
branch
2 times, most recently
from
November 29, 2018 13:54
5c65625
to
515aef1
Compare
bWolfie
reviewed
Nov 29, 2018
carloshenrq
force-pushed
the
config_fullprotect
branch
from
November 29, 2018 16:47
515aef1
to
2d9e720
Compare
Jedzkie
reviewed
Dec 2, 2018
If active, should replace strip status and add new one protected
carloshenrq
force-pushed
the
config_fullprotect
branch
from
December 4, 2018 18:39
2d9e720
to
13d172a
Compare
instead of having
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed
Today, the equip protect status (SC_PROTECTWEAPON, SC_PROTECTHELM, SC_PROTECTARMOR, and SC_PROTECTSHIELD) only apply if there's equip on a respective slot.
Old days, the protect status, apply without the test. So, protect shield work with no shield equip. This PR creates a config that allows going back old days =]
Issues addressed:
There is no issues