Deprecate *getunitname script command #2395
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I give it some thought, I think better split the
*getunitname
deprecation out from #2391Pull Request Prelude
Issues addressed
we have 2 script command do the same thing,
*rid2name
and*getunitname
Changes Proposed
deprecate
*getunitname
because rid2name has been exist since eathena timesalso minor fix rid2name to support elementals
Affected Branches
Known Issues and TODO List
we have to decide which one to deprecate,
better don't have 2 script commands do exact same thing again, like this #2089