-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tech] Move to the electron-vite
build tool
#3218
Conversation
81b219e
to
a758ca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested some things like login, install, play, uninstall, install a wine, filtering, changing settings
all on linux seems to work fine
I didn't test building the app for release though
maybe we can merge this into main so we all use this more during development? not sure what others think
a758ca0
to
aa7cb1d
Compare
faace02
to
f06a6ea
Compare
f90c68e
to
99b93c1
Compare
99b93c1
to
4757464
Compare
b363b45
to
70212ca
Compare
We only use this two times, it's easier to just use the proper path there
This feels a bit more clear than a "random" starting /
70212ca
to
e390a28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as expected
electron-vite is a slightly newer option for building Electron applications with Vite. Other than having some saner defaults and being generally more popular in the ecosystem, it also allows us to finally upgrade to Vite 4, which comes with noticeable speed improvements
I've done some testing of this on Linux and Windows, but due to architectural issues (the great CommonJS vs ESM split), literally any module we import might break with this. This is sadly unavoidable if we want to upgrade to a newer Vite version. If a module like this crops up in the future, we have to add it to
electron.vite.config.ts
'sdependenciesToNotExternalize
arrayDue to this issue, more testing than normal will be necessary for this PR
Use the following Checklist if you have changed something on the Backend or Frontend: