replace opaque error message with something easier for user#160
Open
StuartLittlefair wants to merge 1 commit intomasterfrom
Open
replace opaque error message with something easier for user#160StuartLittlefair wants to merge 1 commit intomasterfrom
StuartLittlefair wants to merge 1 commit intomasterfrom
Conversation
Member
|
I see what you mean about the syntax, something like |
martinjohndyer
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159 by adding a helper routine to crop calibration frames.
Note the nice error message needs to know the type of calibration frame being applied, which leads to this slightly verbose syntax. It would be good if there was a nice way of removing this duplication without adding code to the MCCD class, but I don't think there's a way to infer the calibration type automatically.