feat(navigation): add NavigationActions and the composable SideBarNavigation #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the different routes and screens necessary for the navigation through the app. The SideBarNavigations serves as a Menu which will be available in the main Screens.
Implement the different routes and screens necessary for the navigation through the app. The SideBarNavigations serves as a Menu which will be available in the main Screens.
Start implementing the tests for the different methods of NavigationsActions.
…adle. Implement the tests for SideBarNavigation with some tweaks to the code to make the test tags available. changed gradle build to include mockito imports.
…App into feat/11-add-navigation
Add tests to both test files. Also changed the icons in the SideBarNavigation to make it more visually apealing.
…en if list is empty
…ts.kt Add tests to both test classes, specially for the NavOptions properties which were previously inaccesible through the NavController.
Wylwi
reviewed
Oct 7, 2024
Wylwi
reviewed
Oct 7, 2024
|
Just a few comments about what I saw when looking quickly at the code. Will leave the review to someone else, I have done a lot of them recently :) |
app/src/main/java/ch/hikemate/app/ui/navigation/NavigationActions.kt
Outdated
Show resolved
Hide resolved
…n, update the JVM version
Wylwi
reviewed
Oct 7, 2024
mchac15
changed the title
rBergCode
requested review from
rBergCode
and removed request for
davidholzwarth and
MaelImhof
rBergCode
reviewed
Oct 10, 2024
rBergCode
reviewed
Oct 10, 2024
rBergCode
reviewed
Oct 10, 2024
rBergCode
reviewed
Oct 10, 2024
app/src/main/java/ch/hikemate/app/ui/navigation/NavigationActions.kt
Outdated
Show resolved
Hide resolved
rBergCode
reviewed
Oct 10, 2024
app/src/main/java/ch/hikemate/app/ui/navigation/NavigationActions.kt
Outdated
Show resolved
Hide resolved
rBergCode
reviewed
Oct 10, 2024
app/src/main/java/ch/hikemate/app/ui/navigation/NavigationActions.kt
Outdated
Show resolved
Hide resolved
rBergCode
reviewed
Oct 10, 2024
app/src/main/java/ch/hikemate/app/ui/navigation/NavigationActions.kt
Outdated
Show resolved
Hide resolved
rBergCode
reviewed
Oct 10, 2024
app/src/test/java/ch/hikemate/app/navigation/NavigationActionsTest.kt
Outdated
Show resolved
Hide resolved
rBergCode
reviewed
Oct 10, 2024
app/src/test/java/ch/hikemate/app/navigation/NavigationActionsTest.kt
Outdated
Show resolved
Hide resolved
rBergCode
reviewed
Oct 10, 2024
app/src/main/java/ch/hikemate/app/ui/navigation/SideBarNavigation.kt
Outdated
Show resolved
Hide resolved
rBergCode
reviewed
Oct 10, 2024
app/src/main/java/ch/hikemate/app/ui/navigation/SideBarNavigation.kt
Outdated
Show resolved
Hide resolved
rBergCode
reviewed
Oct 10, 2024
app/src/main/java/ch/hikemate/app/ui/navigation/SideBarNavigation.kt
Outdated
Show resolved
Hide resolved
rBergCode
reviewed
Oct 10, 2024
app/src/main/java/ch/hikemate/app/ui/navigation/SideBarNavigation.kt
Outdated
Show resolved
Hide resolved
rBergCode
reviewed
Oct 10, 2024
app/src/androidTest/java/ch/hikemate/app/navigation/SideBarNavigationTest.kt
Outdated
Show resolved
Hide resolved
rBergCode
requested changes
Oct 10, 2024
|
rBergCode
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces the core navigation functionality for the HikeMate application, setting up the foundation for user flow across various screens.
Key Changes
NavigationActions.kt:This file defines the primary navigation routes and screen names for the different sections of the app. It provides utility functions for navigating between
TopLevelDestinations, allowing seamless transitions within the app's structure.SideBarNavigation.kt:Introduces a sidebar component that serves as the main navigation UI element. This
ModalNavigationDraweris available on most key screens, enabling users to toggle a sidebar menu by clicking the icon in the upper left corner. The menu allows users to navigate through essential parts of the application.Additional Updates
build.gradleto include the necessary dependencies for testing, ensuring the navigation components are covered by relevant unit and UI tests.