Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused-data in xml #334

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: remove unused-data in xml #334

merged 1 commit into from
Dec 19, 2024

Conversation

rBergCode
Copy link
Contributor

Summary

We had un-used data in Color.xml and Strings.xml. This PR removes them.

@rBergCode rBergCode linked an issue Dec 19, 2024 that may be closed by this pull request
Remove unused data in XML #333
Closed
@rBergCode rBergCode requested a review from Wylwi December 19, 2024 21:32
@rBergCode rBergCode self-assigned this Dec 19, 2024
@rBergCode rBergCode added enhancement New feature or request Sprint 10 Active during the dixième sprint labels Dec 19, 2024
@rBergCode rBergCode added this to the Milestone 3 milestone Dec 19, 2024
Wylwi
Wylwi approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@Wylwi Wylwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 89.14% 🍏

There is no coverage information present for the Files changed

@rBergCode rBergCode merged commit 49db7c9 into main Dec 19, 2024
4 checks passed
@rBergCode rBergCode deleted the chore/remove-unused-data-in-xml branch December 19, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wylwi Wylwi Wylwi approved these changes

Assignees

@rBergCode rBergCode

Labels
enhancement New feature or request Sprint 10 Active during the dixième sprint
Projects
None yet
Milestone
Milestone 3
Development

Successfully merging this pull request may close these issues.

Remove unused data in XML
2 participants
@rBergCode @Wylwi