Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: profile soft loop bug #336

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix: profile soft loop bug #336

merged 2 commits into from
Dec 19, 2024

Conversation

Wylwi
Copy link
Contributor

@Wylwi Wylwi commented Dec 19, 2024

If the user experiences an error with something related to the profileViewModel, this error is never cleared, leading to a soft loop. This PR fixes it

@Wylwi Wylwi self-assigned this Dec 19, 2024
@Wylwi Wylwi added bug Something isn't working Sprint 10 Active during the dixième sprint labels Dec 19, 2024
@Wylwi Wylwi added this to the Milestone 3 milestone Dec 19, 2024
@rBergCode rBergCode self-requested a review December 19, 2024 23:08
Copy link
Contributor

@rBergCode rBergCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Thanks

Copy link

github-actions bot commented Dec 19, 2024

Code Coverage

Overall Project 89.51% 🍏
Files changed 100% 🍏

File Coverage
ProfileViewModel.kt 100% 🍏

@rBergCode rBergCode merged commit ddfd63f into main Dec 19, 2024
4 checks passed
@rBergCode rBergCode deleted the fix/profile-soft-loop branch December 19, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Sprint 10 Active during the dixième sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants