Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for organization name changes and adding PR template #9

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

Wylwi
Copy link
Contributor

@Wylwi Wylwi commented Oct 2, 2024

Summary

The project was renamed from FlepMate to HikeMate, leading to token invalidation. Also finally defined the app namespace to change it from the example one.

Details

  • Changed the CI tokens
  • Added a PR template

Wylwi added 2 commits October 2, 2024 10:50
The project was renamed from FlepMate to HikeMate, leading to token invalidation. Also finally defined the app namespace to change it from the example one.
@Wylwi Wylwi requested a review from rBergCode October 2, 2024 09:01
@mchac15 mchac15 self-requested a review October 2, 2024 09:13
mchac15
mchac15 previously approved these changes Oct 2, 2024
Copy link
Contributor

@mchac15 mchac15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We defined the app namespace, which implies to change the directories name. So does this commit
@Wylwi Wylwi force-pushed the ah/initial-setup-update branch from cef1d34 to 681bfc9 Compare October 2, 2024 09:22
@Wylwi Wylwi requested review from mchac15 and removed request for rBergCode October 2, 2024 09:22
@Wylwi Wylwi dismissed mchac15’s stale review October 2, 2024 09:24

New commits

Copy link
Contributor

@mchac15 mchac15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Maël Imhof <mael.imhof@protonmail.com>
Copy link
Contributor

@MaelImhof MaelImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work !

Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Wylwi Wylwi merged commit 06dfd50 into main Oct 2, 2024
1 of 2 checks passed
@Wylwi Wylwi deleted the ah/initial-setup-update branch October 2, 2024 09:32
@Wylwi Wylwi self-assigned this Nov 14, 2024
@MaelImhof MaelImhof added the sprint 0 Active before the first sprint label Nov 15, 2024
@MaelImhof MaelImhof added this to the Milestone 1 milestone Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint 0 Active before the first sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants