Added Dark Mode feature with toggle, fixed header, testimonials & contact section colors.#39
Added Dark Mode feature with toggle, fixed header, testimonials & contact section colors.#39SushritaSingh wants to merge 1 commit intoHimanshusk1:mainfrom
Conversation
…tact section colors
|
@SushritaSingh is attempting to deploy a commit to the Himanshu Singh Kyariya's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
I added the dark theme successfully. Review it Please. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @SushritaSingh, Thanks again for adding the dark mode feature! While the functionality is working well, the current dark mode styling still needs significant improvements. Right now, some UI elements look off — the colors lack harmony, contrast is low in places, and overall it affects readability and the site’s polished look. Could you please focus on enhancing the following areas: Improve background and text color contrast for better readability Refine the color palette for a more cohesive and professional dark theme Adjust buttons, cards, and interactive elements to fit the dark mode style smoothly Ensure all components respond well and look consistent in dark mode If you want, I can share specific color suggestions or examples for reference. Looking forward to a more polished dark mode experience! Thanks for your effort so far |
|
Sure I’ll fix that
…On Sat, 2 Aug 2025 at 7:10 PM, Himanshu Singh Kyariya < ***@***.***> wrote:
*Himanshusk1* left a comment (Himanshusk1/GDF#39)
<#39 (comment)>
Hi @SushritaSingh <https://github.com/SushritaSingh> 👋
Thank you for your contribution! 🌙 The dark mode toggle is a great
addition and it's awesome to see smooth transitions and responsiveness
already in place.
That said, could you please enhance the overall dark theme appearance a
bit more? Currently, after toggling, some UI elements (like backgrounds,
text contrasts, or section highlights) don’t look as polished and may
affect readability or aesthetics.
A few suggestions to consider:
Adjust background and foreground contrast for better visual hierarchy.
Refine color palette to make it more cohesive (especially buttons, cards,
and hover states).
Ensure sufficient contrast ratio for accessibility (you can use tools like
WebAIM Contrast Checker).
Looking forward to the improved version! Let me know if you need any
feedback along the way 😊
Also, assigning you to the related issue now.
Thanks again for your efforts!
—
Reply to this email directly, view it on GitHub
<#39 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BULRWEIEB77IUPTSR74D3AD3LS5WRAVCNFSM6AAAAACC6K2QDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNBWGUYDONZXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Closes #31
🔹 What’s New:
Implemented a Dark Mode using CSS variables and [data-theme="dark"].
Added a theme toggle button to switch between Light and Dark modes.
Used JavaScript + localStorage to remember user’s theme preference across sessions.
Updated all pages to support dynamic color changes for seamless theme switching.
🔹 How It Works:
Clicking the toggle button switches between Light and Dark themes instantly.
User preference is saved in localStorage and applied on page reload.
Colors are managed with CSS variables for easy customization.