Improve spec cases related to search for an option

Hirurg103 · Sep 12, 2018 · c4af314 · c4af314
1 parent feb9ed8
commit c4af314
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 11 deletions.
diff --git a/spec/select2_v2_spec.rb b/spec/select2_v2_spec.rb
@@ -45,12 +45,14 @@
           expect(page).to have_css '.select2-search-choice', text: 'Buy Milk'
         end
 
-        it 'should select with search for an option' do
-          select2 'Buy Milk', css: '#multiple', search: true
+      end
+
+      context 'when searching for an option' do
+        before { select2 'Buy Milk', css: '#multiple', search: true }
 
+        it 'should select an option from search results' do
           expect(page).to have_css '.select2-search-choice', text: 'Buy Milk'
         end
-
       end
 
       context 'creating a dynamic option' do

diff --git a/spec/select2_v3_spec.rb b/spec/select2_v3_spec.rb
@@ -45,19 +45,21 @@
           expect(page).to have_css '.select2-search-choice', text: 'Buy Milk'
         end
 
-        it 'should select with search for an option' do
+        it 'should select an option from select with previously selected values' do
           select2 'Buy Milk', css: '#multiple', search: true
+          select2 'See Malaysia', css: '#multiple', search: true
 
           expect(page).to have_css '.select2-search-choice', text: 'Buy Milk'
         end
 
-        it 'should select an option from select with previously selected values' do
-          select2 'Buy Milk', css: '#multiple', search: true
-          select2 'See Malaysia', css: '#multiple', search: true
+      end
 
+      context 'when searching for an option' do
+        before { select2 'Buy Milk', css: '#multiple', search: true }
+
+        it 'should select an option from search results' do
           expect(page).to have_css '.select2-search-choice', text: 'Buy Milk'
         end
-
       end
 
       context 'creating a dynamic option' do

diff --git a/spec/select2_v4_spec.rb b/spec/select2_v4_spec.rb
@@ -54,10 +54,12 @@
 
       end
 
-      it 'should select with search for an option' do
-        select2 'Buy Milk', css: '#multiple', search: true
+      context 'when searching for an option' do
+        before { select2 'Buy Milk', css: '#multiple', search: true }
 
-        expect(page).to have_css '.select2-selection__choice', text: 'Buy Milk'
+        it 'should select an option from search results' do
+          expect(page).to have_css '.select2-selection__choice', text: 'Buy Milk'
+        end
       end
 
       context 'creating a dynamic option' do