-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ambush.js #230
Create ambush.js #230
Conversation
Well, the code may have a few bugs, but it should work. I need to know how to search in a file for something.
Just checked the build log and it's nothing to do with this code. It's TypeError: Cannot read property '404' of undefined |
Looks like a module is causing issues, would be wise to remove it at this point. Its used in profiles.js. Ill do it later, or you can. |
Ok, the crash with the build is fixed, take a look at the error now. I don't have time to review this now, though I assume you created some new globals/used some that don't exist on wavelength. Double check your work (and make sure its tested & works properly, not just that it dosent crash, I will be checking myself). |
The build error was simply a result of the geoip module returning the same 404 error as addressed in the PR merged earlier today. This code just needs to be updated to reflect those changes and it should work fine after an overall glance. |
I would nonetheless highly recommend a detailed review. |
Not entirely sure what I'm meant to do @Mystifi @HoeenCoder you told me different things. Is this crash a result of some other pr? |
Originally, the build failure was. The issue was fixed in #231 and I re-ran the build. Check this for the list of issues to fix. https://travis-ci.org/HoeenCoder/Wavelength/builds/507729445?utm_source=github_status&utm_medium=notification |
@HoeenCoder I have finished this finally. Checks passed |
On hold at this time, see https://github.com/HoeenCoder/Wavelength/projects and #240 |
Ok maybe that was a bad idea |
We opted to drop this. |
Well, the code may have a few bugs, but it should work. I need to know how to search in a file for something.