This repository was archived by the owner on Nov 10, 2018. It is now read-only.
Simple Interactive Evaluator feature-228 #238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JVonderwell
suggested changes
May 13, 2018
holoclean/holoclean.py
Outdated
| 'default': 1, | ||
| 'type': int, | ||
| 'help': 'Number of inferred values'}), | ||
| (('-inte', '--iteractive'), |
holoclean/holoclean.py
Outdated
| 'type': int, | ||
| 'help': 'Number of inferred values'}), | ||
| (('-inte', '--iteractive'), | ||
| {'metavar': 'Iteractive', |
Contributor
There was a problem hiding this comment.
here and the line below too
| acc = Accuracy(self, truth_path) | ||
| acc.accuracy_calculation() | ||
| if self.holo_env.iteractive: | ||
| acc.interactive_calculation_accuracy() |
Contributor
There was a problem hiding this comment.
we should make the interactive calculation outside of compare_to_truth. The whole point of the interactive calculation is for cases where we don't have a grand truth.
a different method like: 'interactive_evaluation()' that creates an Accuracy and calls interactive_calculation_accuracy() would make more sense.
JVonderwell
approved these changes
May 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.